fix(shell-panel): reset resize state when layout changes - #14364
Merged
jcfranco merged 4 commits intoMay 19, 2026
Conversation
github-actions
Bot
added
the
bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts calcite-sheet and calcite-shell-panel interaction lifecycle so that when interactions are reset (e.g., after reconnecting or reinitializing interact.js), the components can re-read and apply the latest token/CSS-based dimensions rather than continuing to operate on stale overridden sizes.
Changes:
- Gate
setupInteractions()inconnectedCallback()so it only runs on re-connect (whenhasUpdatedis already true). - Clear any inline/block size overrides during
cleanupInteractions()so a subsequent interaction setup uses fresh computed dimensions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/components/src/components/shell-panel/shell-panel.tsx | Reinitialize interactions on reconnect and clear size overrides during interaction cleanup so resets can pick up updated dimensions. |
| packages/components/src/components/sheet/sheet.tsx | Avoid setting up interactions before first render on connect, and clear size overrides during interaction cleanup to ensure resets use updated computed dimensions. |
Contributor
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
Bot
added
the
Stale
github-actions
Bot
removed
the
Stale
jcfranco
added
the
pr ready for visual snapshots
jcfranco
changed the title
jcfranco
force-pushed
the
jcfranco/13986-use-updated-dimensions-on-interaction-reset
branch
from
May 19, 2026 22:20
2a11bba to
ae48599
Compare
jcfranco
changed the title
layout changes
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
packages/components/src/components/shell-panel/shell-panel.tsx:235
- blocking:
disconnectedCallback()also overrides Lit’s hook without callingsuper.disconnectedCallback(), so controllers won’t receivehostDisconnectedand may leave behind listeners/observers. Addsuper.disconnectedCallback()and keepcleanUpInteractions()alongside it.
override disconnectedCallback(): void {
this.cleanUpInteractions();
}
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+325
to
327
| private cleanUpInteractions(): void { | ||
| this.interaction?.unset(); | ||
| } |
Member
Author
There was a problem hiding this comment.
I'll update the rest in a follow-up PR. It should be cleanUp (verb) rather than cleanup (noun).
Member
There was a problem hiding this comment.
Yeah, this is my bad I'm sure :)
Member
Author
There was a problem hiding this comment.
lol not pointing fingers, just appeasing my pedantry. 😂
jcfranco
marked this pull request as ready for review
May 19, 2026 23:02
driskull
approved these changes
May 19, 2026
Comment on lines
+325
to
327
| private cleanUpInteractions(): void { | ||
| this.interaction?.unset(); | ||
| } |
Member
There was a problem hiding this comment.
Yeah, this is my bad I'm sure :)
jcfranco
added
pr ready for visual snapshots
jcfranco
deleted the
jcfranco/13986-use-updated-dimensions-on-interaction-reset
branch
May 19, 2026 23:44
Merged
jcfranco
added a commit
that referenced
this pull request
May 28, 2026
**Related Issue:** N/A ## Summary Aligns with changes from #14364.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #13986
Summary
This addresses an issue where the resize state would be applied when the layout changed from
horizontaltoverticaland vice versa, leading to an incompatible size after the layout change.Notable changes
willUpdate