This repository was archived by the owner on Dec 20, 2024. It is now read-only.
Open
Conversation
paulcpederson
requested review from
SkyeSeitz,
allieorth,
aphilobos and
grecordova
Member
Author
|
To see a diff of the code that changed rather than the entire icon set diff, see this commit: dcf7f42 |
Member
Author
|
/cc @geospatialem |
SkyeSeitz
approved these changes
May 10, 2023
Contributor
SkyeSeitz
left a comment
SkyeSeitz
left a comment
There was a problem hiding this comment.
Thanks for your patience on this review, Paul! I have looked over the set, including assets with multiple paths with opacities, and verified there are no unwanted visual changes to the icons. Appreciate this bug fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that the action that would release automatically is currently failing. This is due to a lack of
package-lock.jsonbeing committed to the repo. I removed our ignore of this file, and installed again, but then ran into an error. It seems that the old version of SVGO we were using is referencing a now defunct depedency so the install will always fail.To address this, I've upgraded to the lastest SVGO version. I've reimplemented our SVGO options to use the new API, so the plugins should be acting mostly the same. Though the build shows lots of icons being changed, if you look at the diffs it is really small stuff like single characters changing in the path data.
Would be good for all you the icon designers to look at this branch and verify that nothing looks out of place.