Skip to content

Add missing virtual destructors to ConfigStreamReader and ConfigStrea… #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EugeneManushkin merged 1 commit into from
Nov 17, 2025
Merged

Add missing virtual destructors to ConfigStreamReader and ConfigStrea… #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions far_plugin/facade/far3/include/far3/config_stream_reader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ namespace Far3
, unsigned maxErrors = static_cast<int>(Plugin::ConfigFieldId::MaxFieldId)
, unsigned maxLines = static_cast<int>(Plugin::ConfigFieldId::MaxFieldId) * 8
);

virtual ~ConfigStreamReader() = default;
virtual Plugin::Config Read(std::istream& stream, Plugin::ConfigDataMapper const& dataMapper) const = 0;
};
}
1 change: 1 addition & 0 deletions far_plugin/facade/far3/include/far3/config_stream_writer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ namespace Far3
public:
static std::unique_ptr<const ConfigStreamWriter> Create();

virtual ~ConfigStreamWriter() = default;
virtual void Write(std::ostream& stream, Plugin::ConfigDataMapper const& dataMapper, Plugin::Config const& config) const = 0;
};
}