Work in Progress - Incomplete Request#1319
Merged
thomas-mangin merged 1 commit intomainfrom Nov 9, 2025
Merged
Conversation
…arios This commit implements extensive test coverage for race conditions that can occur during concurrent BGP connection operations: **Test Coverage:** 1. Simultaneous Bi-directional Connections - Test collision detection when both peers connect simultaneously - Test file descriptor reuse race conditions - Test concurrent incoming/outgoing connection establishment 2. Connection Reset During I/O Operations - Test graceful handling of connection resets during message transmission - Test connection resets during message reception - Test explicit close() during active I/O operations 3. Rapid Connect/Disconnect Cycles - Test for file descriptor leaks under rapid cycling - Test proper cleanup of polling state - Test handling of partial I/O operations during disconnection 4. Polling State Race Conditions - Test concurrent reading() and writing() calls - Test poller cleanup after socket errors - Test timeout handling in polling operations 5. Message Queue Ordering - Test message ordering during concurrent read/write - Test BGP message assembly with fragmented arrivals - Test buffer state consistency during partial reads 6. Connection State Transitions - Test close() during connection establishment - Test idempotent behavior of multiple close() calls - Test I/O operation rejection after close() All 18 tests verify proper synchronization, error handling, and resource cleanup in timing-sensitive scenarios. These tests help ensure ExaBGP's connection handling remains robust under concurrent load conditions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…arios
This commit implements extensive test coverage for race conditions that can occur during concurrent BGP connection operations:
Test Coverage:
Simultaneous Bi-directional Connections
Connection Reset During I/O Operations
Rapid Connect/Disconnect Cycles
Polling State Race Conditions
Message Queue Ordering
Connection State Transitions
All 18 tests verify proper synchronization, error handling, and resource cleanup in timing-sensitive scenarios. These tests help ensure ExaBGP's connection handling remains robust under concurrent load conditions.