Ticket #6329 Update send email screen #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public function getNewInstance() | ||
| { | ||
| $email = parent::getNewInstance(); | ||
| $email->setSendDate(new \DateTime()); |
There was a problem hiding this comment.
i'm not sure this will work. When you set sendDate to "now", then we will send this info to sendgrid, but when it will be received by sendgrid, "now" will be already in the past and i'm not sure sendgrid will ever send that email.
This field is used when you need to send email in the future. If you don't set it, email will be send immediately.
…nto 6329-update-send-email-screen Conflicts: Resources/views/Admin/CRUD/email_send.html.twig
…nto 6329-update-send-email-screen Conflicts: Validator/Constraints/EmailSendConstraintValidator.php
| @@ -58,8 +58,11 @@ protected function configureFormFields(FormMapper $formMapper) | |||
| 'expanded' => false, | |||
| 'required' => false, | |||
| )) | |||
| ->add('isHtmlContent', 'checkbox', array( | |||
| 'required' => false | |||
| ->add('sendImmediately', 'checkbox', array( | |||
There was a problem hiding this comment.
i believe all emails by default will be sent immediately, except when you set schedule date
|
You have some mistakes in validator logic, please figure it out and fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://exercise.codebasehq.com/projects/development/tickets/6329