Try with log file instead of nexus file. #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the pynxtools dependency to use a different branch for testing with log files instead of nexus files.
- Updated pynxtools dependency source branch from
mastertouse-log-files-in-tests
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mkuehbach
requested changes
Oct 13, 2025
Contributor
mkuehbach
left a comment
mkuehbach
left a comment
There was a problem hiding this comment.
PRs need to have a proper description that summarizes which problem, bug, or other issue the PR addresses.
Tests were refactored here. If that should go to main reminder to update to a proper version of pynxtools
RubelMozumder
force-pushed
the
RepalceNexusFile
branch
from
a9307d4 to
7cf9a54
Compare
RubelMozumder
commented
Oct 20, 2025
| "Operating System :: OS Independent", | ||
| ] | ||
| dependencies = [ | ||
| "pynxtools>=0.12.0", |
Collaborator
Author
There was a problem hiding this comment.
Before merging, get back to the pynxtools PyPI version.
RubelMozumder
commented
Oct 20, 2025
Comment on lines
+24
to
+25
| # "pynxtools>=0.12.0", | ||
| "pynxtools @ git+https://github.com/FAIRmat-NFDI/pynxtools.git@use-log-files-in-tests#egg=pynxtools", |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| # "pynxtools>=0.12.0", | |
| "pynxtools @ git+https://github.com/FAIRmat-NFDI/pynxtools.git@use-log-files-in-tests#egg=pynxtools", | |
| "pynxtools>=0.12.0", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we try to use the log file instead of the nexus file to test the readers using the test framework of pynxtools.
Follow PR in pynxtools.