Draft: formula parsing in multiformatreader #524
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaspie
force-pushed
the
521-add-support-for-formulas-in-multiformat-reader
branch
from
dfeb9e1 to
0a21521
Compare
lukaspie
force-pushed
the
521-add-support-for-formulas-in-multiformat-reader
branch
from
0a21521 to
300c07c
Compare
Collaborator
|
Is this still hot? |
Collaborator
Author
I want to come back to this at some point soon-ish, so please leave the PR open. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rettigl this is an initial draft for what we were discussing in the PR.
The initial structure seems to work, but the actual formula evaluation doesn't yet, mostly because the regex for replacing with the key resolving is broken.
I'll continue working on this after my vacation (so from the 27th).