fix(scons): strip annobin/hardened specs after configuration phase#17
Merged
movingpictures83 merged 1 commit intoJun 18, 2026
Conversation
The previous fix only stripped RHEL annobin specs in create_base_environment(), but Perl's ParseConfig (ccopts/ldopts) re-injected -specs=redhat-annobin-cc1 and related flags during the configuration phase, causing gcc-annobin plugin version mismatch failures (built for gcc 8.5.0, running gcc 9.5.0). - Add redhat-hardened-ld to the specs filter list - Filter LINKFLAGS and SHLINKFLAGS in addition to compile flags - Call _remove_annobin_flag and _strip_lto_flags after config.Finish() to catch all flags injected by ParseConfig during configuration Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-specs=flags after the configuration phase, not just before it — Perl'sParseConfig(ccopts/ldopts)re-injects them duringconfigure_perl, causing a gcc-annobin plugin version mismatch error (plugin built for gcc 8.5.0 but run with gcc 9.5.0)redhat-hardened-ldto the specs filter (was missing)LINKFLAGSandSHLINKFLAGSin addition to compile-flag variablesFollows up on #16 which stripped the specs only in
create_base_environment()— insufficient becauseParseConfigre-adds them.Test plan
sconscompletes successfully with nogcc-annobinerrors-specs=...redhat-annobin-cc1or-specs=...redhat-hardened-cc1🤖 Generated with Claude Code