Conversation
4 tasks
This was referenced Apr 28, 2026
ptheywood
force-pushed
the
amdgpu
branch
2 times, most recently
from
June 5, 2026 16:51
6487086 to
6779e5e
Compare
The (vendored) 3rd party action for the CLA bot is no longer being updated, and does not support node 24. This mitigates the issue until fall 2026
…d GCC >= 11 now required
Our minimum CMake updated for CUDA C++20 allows us to use this.
… used in debug-only macros (DTHROW)
…-internal-declaration warnings
…suite via int division/multiplication
…StateWriter This was only used for a workaround in rapidJSON
…re no longer required due to cleaner abstraction
4 tasks
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds AMD GPU support via HIP / ROCm
Caution
This is still a WIP - do not review, merge or expect CI to be happy
It will be rebased many times, and may become the base branch for other AMD/HIP/ROCm/clang related PRs so they can all be merged into
masterin a single go.flamegpu::detail::gpunamespace.Decisions to make during review
FLAMEGPU_GPU=CUDA/HIP/OFF- Best I've come up with, but not super keen on this cmake option name.FLAMEGPU_CURAND_ENGINE- deprecate and rename? Its a bit grim to do with it being a cache var not an option.flamegpu::detail::gpu::Stream_tis used in classes which belong in the public API (but not sure if it is actaulyl part of the true public API, i.e. users arent' supposed to provide those values themselves?) Should this beflamegpu::gpu::Stream_tinstead?CUDASimulation->GPUSimulationetc? with a deprecated type alias?using X [[deprecated(("msg")]] = Yshould make that trivial, butCUDAConfigmeans a deprecated member is needed too to fully make the change, so is just a decent chunk more effort.defined(FLAMEGPU_USE_CUDA)vsifdef FLAMEGPU_USE_CUDA. Maybe do HIP first and fallback to the CUDA version so intellisense doesn't get offended?TODO: DO NOT MERGEin test suite, where wrapper function changes happened but I didn't update the test suite.As of 2026-06-10 tests pass with: