Fix PoChecker instance isolation, method naming, and boolean simplification#6
Merged
Merged
Conversation
… PoChecker Agent-Logs-Url: https://github.com/FOSSBilling/poLanguageChecker/sessions/71c52364-8543-4ca5-a8d3-c22505437ce2 Co-authored-by: admdly <2807620+admdly@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix class variable totalIssues to be an instance variable
Fix PoChecker instance isolation, method naming, and boolean simplification
May 8, 2026
admdly
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
totalIssueswas a class variable, causing counts to accumulate across multiplePoCheckerinstances. The custom dictionary suggestion method also had a typo in its name (CustomDic→CustomDict), and a redundant ternary was used to produce a boolean.Changes
totalIssues = 0from class body toself.totalIssues = 0in__init__, ensuring each instance maintains its own count.suggestCorrectionsFromCustomDic→suggestCorrectionsFromCustomDict(spelling fix); updated all call sites accordingly.True if <expr> else Falsewithbool(<expr>).Original prompt