fix: dont prematurely end deadline command in ParallelDeadlineGroup#32
Merged
Merged
Conversation
Collaborator
|
I don't mind adding Mock. |
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Requests
One approach to fixing bug with ParallelDeadlineGroup when using SequentialCommandGroup as the deadline command. This fix ensures that when commands finish during execute() that end() will not be called on the deadline command. Instead end() will be called on the deadline command when the ParallelDeadlineGroup's end method is called.
Don't know if its OK to introduce mockito as a test dependency - if not, I'll be happy to drop it, just let me know.
What kind of change does this PR introduce?
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.
Please make sure your PR satisfies the requirements of the contributing page