Conversation
android/termuxbuild.sh
Outdated
| @@ -0,0 +1,114 @@ | |||
| #0. install build tools: | |||
There was a problem hiding this comment.
I don't think anybody would read this.
There was a problem hiding this comment.
What I mean is that it's better to add checks if command exists (like with command -v foo > /dev/null) and throw an error if it's not.
In fact, if we go with this approach, there better be some good error handling.
There was a problem hiding this comment.
Ok, i need to improve script, closing pull request
There was a problem hiding this comment.
Do not do stupid things like closing PR because opening a new one will dismiss all review comments.
If you want to add or modify something, you can just push new commits to the same branch.
| sed -i '/<\/queries>/a<uses-sdk android:minSdkVersion="3" android:targetSdkVersion="34"\/>' build/AndroidManifest.xml | ||
| #default manifest file not containing this lines, so we just copying into it | ||
|
|
||
| aapt package ${AGRF} |
There was a problem hiding this comment.
This whole method is somewhat too stupid.
While you can obviously do that, ever slight change in the code like adding some external dependencies, would require changes in this script
Better figure out how to call gradle instead.
There was a problem hiding this comment.
I agree with you, but gradle doesnt work in termux "out of box", you have to do many goofy tricks to make gradle work on termux + gradle has many bloat dependencies, no one need that for building dummy xash mod launcher
There was a problem hiding this comment.
I agree with you, but gradle doesnt work in termux "out of box", you have to do many goofy tricks to make gradle work on termux + gradle has many bloat dependencies, no one need that for building dummy xash mod launcher
There was a problem hiding this comment.
You can't assume that nobody needs it because this is just a sample.
That's honestly just my opinion. Maybe @nekonomicon or @Velaron has some different thoughts on this matter.
|
Исправил ошибки, теперь всё автоматически скачивается, думаю сойдёт |
Goofy script, but it works