Skip to content

Add termux build script#558

Open
erfty125 wants to merge 4 commits intoFWGS:masterfrom
erfty125:master
Open

Add termux build script#558
erfty125 wants to merge 4 commits intoFWGS:masterfrom
erfty125:master

Conversation

@erfty125
Copy link

@erfty125 erfty125 commented Feb 6, 2026

Goofy script, but it works

@@ -0,0 +1,114 @@
#0. install build tools:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think anybody would read this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean is that it's better to add checks if command exists (like with command -v foo > /dev/null) and throw an error if it's not.

In fact, if we go with this approach, there better be some good error handling.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, i need to improve script, closing pull request

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not do stupid things like closing PR because opening a new one will dismiss all review comments.

If you want to add or modify something, you can just push new commits to the same branch.

sed -i '/<\/queries>/a<uses-sdk android:minSdkVersion="3" android:targetSdkVersion="34"\/>' build/AndroidManifest.xml
#default manifest file not containing this lines, so we just copying into it

aapt package ${AGRF}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole method is somewhat too stupid.

While you can obviously do that, ever slight change in the code like adding some external dependencies, would require changes in this script

Better figure out how to call gradle instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you, but gradle doesnt work in termux "out of box", you have to do many goofy tricks to make gradle work on termux + gradle has many bloat dependencies, no one need that for building dummy xash mod launcher

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you, but gradle doesnt work in termux "out of box", you have to do many goofy tricks to make gradle work on termux + gradle has many bloat dependencies, no one need that for building dummy xash mod launcher

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't assume that nobody needs it because this is just a sample.

That's honestly just my opinion. Maybe @nekonomicon or @Velaron has some different thoughts on this matter.

@erfty125 erfty125 closed this Feb 6, 2026
@erfty125 erfty125 reopened this Feb 6, 2026
@erfty125
Copy link
Author

erfty125 commented Feb 6, 2026

Исправил ошибки, теперь всё автоматически скачивается, думаю сойдёт

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants