Hotfix RetargetBasePose being null when it shouldn't#279
Open
neptuwunium wants to merge 1 commit intoFabianFG:masterfrom
Open
Hotfix RetargetBasePose being null when it shouldn't#279neptuwunium wants to merge 1 commit intoFabianFG:masterfrom
neptuwunium wants to merge 1 commit intoFabianFG:masterfrom
Conversation
Collaborator
|
Is there any specific game with this issue? |
Contributor
Author
|
Fragpunk character animations. |
Collaborator
|
This is a global issue with FNames as the comparison is most of the time performed via Index/Number rather than Text value. |
Contributor
Author
|
I believe the unreal way is to hash the names and compare that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfixes an issue that happens when one of the two is comparing via index and the other via strings (I think? I tried forcing GetHashCode to evaluate the string content and it did not fix it.)
Additive animations (usually faces) and animations using a shared skeleton end up being catastrophically distorted without this change.
Note; if it is an issue with FName comparison in
Dictionary<FName, TValue>this issue could emerge in other places