Fix groupKey assignment in build method#5346
Open
MaxURhino wants to merge 1 commit intoFabricMC:1.16from
Open
Conversation
Member
|
I worry this is going to set a bad precedence that our APIs all support passing Identifier's without a path. We do this kind of thing in many other places without checking the path. In general I dont think I have ever seen an Identifier without a path. I think this is really a bug with the mods using this, they should set a reasonable path, even if its |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made, so if the
pathof theIdentifierwon't have the path, it will remove the dot at the end.