Open
Conversation
Owner
|
Amazing work!, but for now I preferer to bundle the upstream IngridHQ/Zebrash without changing their implementation. A PR/Issue in https://github.com/ingridhq/zebrash may get this in the original lib. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the barcode rendering, in order to make sure everything works i also put in the Zbrash files inside of the project for easier access and edit, the bug was actually inside of that so after fixing the data handling, i build the WASM again using go and then build the project, tested it for our internal project and it works flawlessly.
We have had an issue with the barcode handling it was not being properly rendered and was being gutted off