refactor: consolidate dependencies to use fastlane-contracts directly#2
Merged
Conversation
- Remove fastlane-task-manager submodule (now part of fastlane-contracts) - Update remappings to @fastlane-contracts/=lib/fastlane-contracts/src/ - Update all imports to use fastlane-contracts paths: - ITaskManager: @fastlane-contracts/task-manager/interfaces/ - IShMonad: @fastlane-contracts/shmonad/interfaces/ - Common interfaces: @fastlane-contracts/common/ - Remove redundant src/interfaces/shmonad/ folder - Update VS Code settings to match new remappings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the separate
fastlane-task-managersubmodule and migrates all imports to use the consolidatedfastlane-contractslibrary directly, eliminating dependency redundancy and simplifying the project structure.Changes Made
lib/fastlane-task-manager@fastlane-task-manager/src=to@fastlane-contracts/=lib/fastlane-contracts/src/@fastlane-contracts/task-manager/interfaces/ITaskManager.sol@fastlane-contracts/shmonad/interfaces/IShMonad.sol@fastlane-contracts/common/{IAddressHub,Directory}.solsrc/interfaces/shmonad/folder (now using lib interfaces directly)Testing Status
✅ All builds and tests pass with new import structure
forge build: Successful compilation with only warningsBattleNadsMovementTestare pre-existing and unrelated to import changes)