fix(#4218): avoid duplicate injection on fields #5224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sponding injected constructor parameter is available
giulong
commented
Jul 13, 2025
| @@ -816,6 +816,9 @@ protected void addInjectables(DeserializationContext ctxt, | |||
|
|
|||
| for (Map.Entry<Object, AnnotatedMember> entry : raw.entrySet()) { | |||
| AnnotatedMember m = entry.getValue(); | |||
| if (m.isIgnoreInjection()) { | |||
There was a problem hiding this comment.
We avoid creating a redundant ValueInjector for fields whose injection was already performed via constructor properties.
| * | ||
| * @since 2.20 | ||
| */ | ||
| protected boolean _ignoreInjection; |
There was a problem hiding this comment.
AnnotatedMembers cannot have per-call state (one instance created perAnnotatedClass; concurrentreadValue()calls would have conflict).So this cannot be done.
Ignore above, I misread code.
|
I like the concept, although would prefer not adding configuring state in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a quite deep analysis on #4218, I ended up implementing what was also suggested in this comment.
This way, when there are both creator properties and fields with the same injection, we mark the annotated field to be ignored when creating the corresponding injectable.
We ignore fields instead of constructor properties considering that constructor injection happens before field injection, and users may need the injected value in the constructor to do any additional logic on their side.
This seems to solve #2678 as well.
Waiting for feedbacks and improvements