feat: support TableHeader and make sortType optional #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this schema change is okay to merge, as it's backwards-compatible (the new Header types are optional children) |
umbobabo
reviewed
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were relying on the
heading:trueproperty on TableCell to determine if it's a<th>- but we didn't really have anything to indicate the<thead>. This meant that consumers like cp-content-pipeline were doing wacky things like pulling out the first row, to put into a th.Instead, lets be explicit and define a TableHeader.
This change also makes
sortTypeoptional. It is considered optional in cp-content-pipeline already (presumably because we have tables that don't define it) , so this makes the types in content-tree compatible.cp-content-pipeline update: https://github.com/Financial-Times/cp-content-pipeline/pull/1399
spark update : TODO