fetch-codereview

IMS Community review of the FETCH codebase

You can view all the sections and files in the ⬅️file tree.

Intro

This Code Review is intended for a technical audience with a desire to improve the FETCH codebase. For a non-technical summary and overview please see the [preliminary analysis](Link to Preliminary Analysis Here).

Table of Contents

• Workflows
  • Routing
  • Shelving
  • Accession
  • Refile
• Bug Investigations
  • Barcode Lag
  • Duplicate Verification
  • Offline Refile
  • Slow Verification List
• Design
  • Shelf Renumbering
  • Shipping/Receiving
• Dependencies
  • Python
  • Javascript
• Deployment
  • Local
  • Single Server
  • Kubernetes

Code Review

The issues raised in the preliminary analysis (security aside) point to a lack of overall architecture and design principles.

• Fat Model / Skinny Controller
• Ports / Adapters
• Imperitive Shell / Functional Core
• MVC/MVVM