Repository navigation
DBF: physical count refresh correctness and error forwarding - #187
Merged
bedipritpal merged 1 commit intoOct 9, 2026
Merged
bedipritpal merged 1 commit into
bedipritpal merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 2: physical record-count refresh correctness and error forwarding, on upstream d64064d after PR186.
One commit, 12 files (+223/-28), with focused tests and scope doc. No OPENADS_FRESH_COUNTS switch, client count-cache policy, ordered-position optimization, Harbour core, protocol, security-policy or CI/workflow changes. Cache hits still follow the existing policy; this fixes the result when a physical refresh occurs.
Credit/provenance: Pritpal Bedi's cumulative mtfix41 testing supports the fork release. Seven driver/wrapper/Table files and scoped local/server count-forwarding hunks match released mtfix41 source. This is not a new isolated Vouch test of upstream.
Local Linux GCC11 Debug normal and TLS: focused 7 cases/124 assertions each; wider normal 121 cases/91,766 assertions and TLS 122 cases/91,777 assertions, all passed. Counts overlap. Warnings-as-errors OFF; slow/flaky/stress name patterns excluded. No full uninterrupted CTest, fresh hosted cross-platform gates or Vouch validation of this port claimed.
Separate existing issue: an 80-row partially encrypted table with only row2 encrypted fails reopen5000 on unchanged upstream too (short bitmap). Not fixed here. Final count regression uses a complete bitmap and verifies count80 before/after reopen; it passes. See the private review note for the retained finding and build-interruption details.