Fixes splunk client authentication issue #83
Merged
+31
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TyMarc
approved these changes
Feb 7, 2025
xvaier
reviewed
Feb 7, 2025
xvaier
reviewed
Feb 7, 2025
xvaier
approved these changes
Feb 7, 2025
Contributor
xvaier
left a comment
xvaier
left a comment
There was a problem hiding this comment.
This looks like a good fix, maybe remove the console log of the username, but otherwise lgtm
markkasaboski
force-pushed
the
mark/splunk-client-auth
branch
from
1196a15 to
32cdad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gitlab.com/flaresystems/ticket-tracker/-/issues/1683
If a user encounters a Splunk client authentication issue, they will now be able to find this error message in the Splunk internal log. Though, the likelihood of anyone seeing this error is slim. The account of the user who first configured the app will have to have been deleted.