Open
Conversation
manishPatwari
requested review from
muskeinsingh,
naqvitalha and
rajatgupta26
naqvitalha
reviewed
Sep 10, 2018
| const viewabilityTracker = this._virtualRenderer.getViewabilityTracker(); | ||
| return viewabilityTracker ? viewabilityTracker.getLastActualOffset() + this.props.distanceFromWindow! : 0; | ||
| let currentOffset = (viewabilityTracker ? viewabilityTracker.getLastActualOffset() : 0); | ||
| if (currentOffset > this.props.distanceFromWindow) { |
Collaborator
There was a problem hiding this comment.
While this will fix the specific issue internally, this doesn't look correct. An example would be having scrolled very little such that it is < distanceFromWindow. We will get 0 as the current offset which is incorrect because there indeed is a valid scroll offset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.