Fix _queueStateRefresh not working after previously being frozen by react-freeze#787
Open
bernhardoj wants to merge 1 commit intoFlipkart:masterfrom
Open
Fix _queueStateRefresh not working after previously being frozen by react-freeze#787bernhardoj wants to merge 1 commit intoFlipkart:masterfrom
bernhardoj wants to merge 1 commit intoFlipkart:masterfrom
Conversation
Merged
49 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the list is frozen by
react-freeze,componentWillUnmountis called which sets_isMountedtofalse. When unfrozen,_isMountedstays atfalse. This causes_queueStateRefreshto not working which prevents the relayouting.This PR fixes it by resetting
_isMountedtotrueincomponentDidMount.