Skip to content

Conversation

tmpsantos
Copy link
Contributor

Upgrade dependencies and add integration tests.

Also checking-in the pubspec.lock to make sure we test the same version that we ship when there is a problem.

We want to make sure the CI is testing the exact same version
we are releasing to the public. Lock the dependencies to make
error reproduction more reliable.
@tmpsantos tmpsantos force-pushed the tmpsantos/upgrade branch 6 times, most recently from 4c809ff to 521221c Compare January 30, 2025 23:12
Copy link
Collaborator

@aemelyanovff aemelyanovff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, I love the test!

All my comments are nits and entirely optional, feel free to ignore them.

@tmpsantos tmpsantos force-pushed the tmpsantos/upgrade branch 2 times, most recently from 4a14a5d to 2caef48 Compare January 31, 2025 01:59
The idea is to test exporting code using Dart test runner,
it will make it easier to write cross platform integration
tests for the various command line options.
This exception catch block was silently ignoring
error such as 'rate limited'.
Add a test that will export and build using our various flags
and check if the command is behaving as expected on all the
platforms we support.
Build tests are going to take over 10 min
@tmpsantos tmpsantos merged commit 3e8866a into main Jan 31, 2025
5 checks passed
@tmpsantos tmpsantos deleted the tmpsantos/upgrade branch January 31, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants