This repository was archived by the owner on Jun 13, 2025. It is now read-only.
await connect for subscription#99
Open
barbalex wants to merge 3 commits into
Open
Conversation
This reverts commit 8329e2a.
|
any chance this is reviewed and merged? otherwise we keep getting Error: HasuraRequestError: an operation already exists with this id.... |
|
and the problem continues. Need to merge this commit |
Contributor
|
this branch has conflicting |
Author
|
Since I created this pull request, the code has been changed from: if (snapmap.keys.isNotEmpty && !_isConnected) {
// ignore: unawaited_futures
_connect();
} else if (_isConnected) {
final input = querySubscription(snapshot.query);
sendToWebSocketServer(input);
}
return snapshot;to: ///If the snapmap keys is not empty and it's not connected, connects
///else if is connected, the input receives the query subscription and
///send it to web socker server
if (snapmap.keys.isNotEmpty && !_isConnected) {
// ignore: unawaited_futures
_connect();
await Future.delayed(const Duration(milliseconds: 500));
} else if (_isConnected) {
final input = querySubscription(snapshot.query);
sendToWebSocketServer(input);
}
/// returns the snapshot
return snapshot;I can't tell whether that solves the issue (maybe better). I am not using flutter any more. So maybe this pull request does not make sense any more? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #90
When creating a subscription hasura_connect checks if a connection already exists. If not, it creates it before returning the snapshot. But it returns the snapshot without awaiting the connection to be established: https://github.com/Flutterando/hasura_connect/blob/master/lib/src/presenter/hasura_connect_base.dart#L204.
I forked this repo and the corrected version works for me. I must admit I have not understood all of the code under hasura_connect's hood though. So hopefully this is the right thing to do.