fix: skip extractor loading in infer for non-composable keys#154
Merged
FluxxField merged 1 commit intomasterfrom Mar 13, 2026
Merged
fix: skip extractor loading in infer for non-composable keys#154FluxxField merged 1 commit intomasterfrom
FluxxField merged 1 commit intomasterfrom
Conversation
When infer motions receive non-composable keys like dd, di, da (and their y/c variants), no composable motion populates the extractor field. module_loader.get_modules() was still requesting "extractor", falling back to "default" which doesn't exist, logging a spurious error. Only request the extractor module when a composable motion has actually set it. The fallback path at line 103+ already handles non-composable keys gracefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dd,di,da(andy/cvariants) were still producing theextractor 'default' not found in registryerrorinfer.run()was always requesting the"extractor"module frommodule_loader, even for non-composable keys where no extractor is setTest plan
dw,yw,cw— composable motions work correctlydd,yy,cc— native line operations, no errordi(,da",yi{— native text objects, no error