Skip to content

Fix layout for "There are other correct answers." checkbox#187

Merged
PhilippImhof merged 1 commit into
FormulasQuestion:mainfrom
PhilippImhof:fix-style
May 25, 2025
Merged

Fix layout for "There are other correct answers." checkbox#187
PhilippImhof merged 1 commit into
FormulasQuestion:mainfrom
PhilippImhof:fix-style

Conversation

@PhilippImhof

Copy link
Copy Markdown
Collaborator

Currently, the checkbox "There are other correct answers." is too close to the input field for model answers. This is due to some style tweaking done by core's multichoice question.

This PR "overrides the override" and brings back the normal layout.

@coveralls

coveralls commented Apr 17, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 15236655826

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 96.847%

Totals Coverage Status
Change from base Build 15236321570: -0.4%
Covered Lines: 4055
Relevant Lines: 4187

💛 - Coveralls

@PhilippImhof

Copy link
Copy Markdown
Collaborator Author

Waiting to see what happens in MDL-85240 before merging this one.

@PhilippImhof

Copy link
Copy Markdown
Collaborator Author

MDL-85240 has been merged to the main branch, i. e. it will be included in Moodle 5.1 and later only. Therefore, it makes sense to merge this PR and keep the workaround for some years at least.

@PhilippImhof PhilippImhof merged commit 1cef938 into FormulasQuestion:main May 25, 2025
26 of 46 checks passed
@PhilippImhof PhilippImhof deleted the fix-style branch May 25, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants