Also accept numeric strings when numbers are needed#202
Merged
Conversation
Pull Request Test Coverage Report for Build 14819149286Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #201
PHP typically uses "type juggling" to dynamically convert types according to the context, e. g.
"12" / "2"is perfectly acceptable. Even more, the result will be of typeint.This PR changes the evaluator's behaviour to follow PHP's principle and accept numeric strings in all places where numbers are expected.
This has one side-effect: as PHP uses a special string concatenation operator (
.) whereas we use+for this purpose, a choice has to be made w.r.t. priority. The decision is that the+operator is basically trying to add things and only falls back to mean concatenation if both arguments are non-numeric strings. If the user really wants to concatenate"1"and"2", they must use thejoin()function instead.