Skip to content

Enhance Filters (Invoke-FGTRestMethod) #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Enhance Filters (Invoke-FGTRestMethod) #95

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
24e1179
removed line from filter section
Tuurtje Apr 10, 2020
db657bf
Fixed non working parameter groups and added remaining filter types
Tuurtje Apr 10, 2020
2f11b59
Corrected parametersets and added remaining filter types
Tuurtje Apr 10, 2020
e43973d
Removed the direct filter option
Tuurtje Apr 14, 2020
b88782f
Fixed Parametersets and added extra types
Tuurtje Apr 14, 2020
727d2a2
Fixed parametersets and added filter types
Tuurtje Apr 14, 2020
95836a7
Update ippool.ps1
Tuurtje Apr 14, 2020
9c4afff
Fixed parametersets and added filter types
Tuurtje Apr 14, 2020
5562f7d
Fixed parametersets and added filter types
Tuurtje Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions PowerFGT/Private/RestMethod.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,18 +67,14 @@ function Invoke-FGTRestMethod {
[switch]$skip,
[Parameter(Mandatory = $false)]
[String[]]$vdom,
[Parameter(Mandatory = $false)]
[Parameter (ParameterSetName = "filter")]
[Parameter(Mandatory = $false, ParameterSetName = "filter")]
[String]$filter,
[Parameter(Mandatory = $false)]
[Parameter (ParameterSetName = "filter_build")]
[Parameter(Mandatory = $false, ParameterSetName = "filter_build")]
[string]$filter_attribute,
[Parameter(Mandatory = $false)]
[ValidateSet('equal', 'contains')]
[Parameter (ParameterSetName = "filter_build")]
[Parameter(Mandatory = $false, ParameterSetName = "filter_build")]
[ValidateSet('equal', 'notequal', 'contains', 'notcontains', 'less', 'lessorequal', 'greater', 'greaterorequal')]
[string]$filter_type,
[Parameter (Mandatory = $false)]
[Parameter (ParameterSetName = "filter_build")]
[Parameter (Mandatory = $false, ParameterSetName = "filter_build")]
[psobject]$filter_value,
[Parameter(Mandatory = $false)]
[psobject]$connection
Expand Down Expand Up @@ -132,9 +128,27 @@ function Invoke-FGTRestMethod {
"equal" {
$filter_value = "==" + $filter_value
}
"notequal" {
$filter_value = "!=" + $filter_value
}
"contains" {
$filter_value = "=@" + $filter_value
}
"notcontains" {
$filter_value = "!@" + $filter_value
}
"less" {
$filter_value = "<" + $filter_value
}
"lessorequal" {
$filter_value = "<=" + $filter_value
}
"greater" {
$filter_value = ">" + $filter_value
}
"greaterorequal" {
$filter_value = ">=" + $filter_value
}
#by default set to equal..
default {
$filter_value = "==" + $filter_value
Expand Down Expand Up @@ -169,4 +183,4 @@ function Invoke-FGTRestMethod {

}

}
}
31 changes: 22 additions & 9 deletions PowerFGT/Public/cmdb/firewall/address.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,16 @@ function Get-FGTFirewallAddress {

Get address contains with *FGT*

.EXAMPLE
Get-FGTFirewallAddress -filter "name=@FGT,fqdn=@FGT"

Get address contains with *FGT* OR fqdn contains *FGT*

.EXAMPLE
Get-FGTFirewallAddress -filter "name=@FGT&fqdn!@FGT"

Get address contains with *FGT* AND NOT fqdn contains *FGT*

.EXAMPLE
Get-FGTFirewallAddress -uuid 9e73a10e-1772-51ea-a8d7-297686fd7702

Expand All @@ -209,17 +219,16 @@ function Get-FGTFirewallAddress {
[string]$name,
[Parameter (Mandatory = $false, ParameterSetName = "uuid")]
[string]$uuid,
[Parameter (Mandatory = $false)]
[Parameter (ParameterSetName = "filter")]
[Parameter(Mandatory = $false, ParameterSetName = "filter")]
[String]$filter,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't really like the idea to have directly filter parameter.. but prefer we can build filter with filter_type, attribute...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oke i will remove it. Advanced searches can be done with invoke-FGTRestMothode if needed. is the parameter name-change (filter -> filter_build) oke? This will make it consistant with Invoke-FGTRestMethode. If not i will change it back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for change ParameterName

[Parameter (Mandatory = $false, ParameterSetName = "filter_build")]
[string]$filter_attribute,
[Parameter (Mandatory = $false)]
[Parameter (ParameterSetName = "name")]
[Parameter (Mandatory = $false, ParameterSetName = "name")]
[Parameter (ParameterSetName = "uuid")]
[Parameter (ParameterSetName = "filter")]
[ValidateSet('equal', 'contains')]
[Parameter (ParameterSetName = "filter_build")]
[ValidateSet('equal', 'notequal', 'contains', 'notcontains', 'less', 'lessorequal', 'greater', 'greaterorequal')]
[string]$filter_type = "equal",
[Parameter (Mandatory = $false)]
[Parameter (ParameterSetName = "filter")]
[Parameter (Mandatory = $false, ParameterSetName = "filter_build")]
[psobject]$filter_value,
[Parameter(Mandatory = $false)]
[switch]$skip,
Expand Down Expand Up @@ -261,6 +270,10 @@ function Get-FGTFirewallAddress {
$invokeParams.add( 'filter_type', $filter_type )
}

if ( $filter) {
$invokeParams.add( 'filter', $filter )
}

$response = Invoke-FGTRestMethod -uri 'api/v2/cmdb/firewall/address' -method 'GET' -connection $connection @invokeParams

$response.results
Expand Down Expand Up @@ -463,4 +476,4 @@ function Remove-FGTFirewallAddress {

End {
}
}
}
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,6 @@ For `Invoke-FGTRestMethod` and `Get-XXX` cmdlet like `Get-FGTFirewallAddress`,
...

```
Actually, support only `equal` and `contains` filter type

### Address Group

Expand Down