Fix excessive sync job spawning #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoschwarzer
force-pushed
the
feature/job-names
branch
5 times, most recently
from
d38d686 to
c267d30
Compare
timoschwarzer
force-pushed
the
feature/job-names
branch
from
c267d30 to
c7b5293
Compare
johnnynotsolucky
approved these changes
Nov 7, 2025
Member
johnnynotsolucky
left a comment
johnnynotsolucky
left a comment
There was a problem hiding this comment.
@timoschwarzer great work figuring this out!
Changes look good to me. I had one comment on the Source::get() function, and I think this is ready.
timoschwarzer
force-pushed
the
feature/job-names
branch
from
c7b5293 to
acca92f
Compare
Member
|
I haven't forgotten to release this and #17! I'm hoping to get to it soon. |
Contributor
Author
|
No worries! I have pinned my composer.json to my fork for the time being 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake in #17 where I made
Syncjobs sync child instead of parent elements, then you @johnnynotsolucky correctly tried to fix that in another place causing the resulting code to sync parent and child elements, which then would also sync their child elements, resulting in a huge number of unnecessarySyncjobs to spawn when saving an entry that is inside a dependency chain.Apart from that, this PR adds a QoL feature to define a
namefunction that returns the name of a source for a given source handle. This is completely optional and only used for job descriptions. E.g. it now showsSync 'Element title' (index name)instead ofSync 12345678 in index name. That was helpful for debugging the above problem and I thought it could be useful in the future.