This repository was archived by the owner on Nov 13, 2024. It is now read-only.
add docker file En version#184
Open
samsesh wants to merge 2 commits into
Open
Conversation
Author
|
I forgot to add this line at the beginning of the install.sh file |
|
@samsesh check this one https://github.com/Chasing66/x-ui |
|
Hello dear, can you put the expiration date for each user that is added in the next edit |
hoseinnikkhah
suggested changes
Jan 26, 2023
hoseinnikkhah
left a comment
hoseinnikkhah
left a comment
There was a problem hiding this comment.
There were some spelling issues and wrong grammar, I tried to fix them all here.
Nice job by the way.
| if [ $# == 0 ]; then | ||
| last_version=$(curl -Ls "https://api.github.com/repos/FranzKafkaYu/x-ui/releases/latest" | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/') | ||
| if [[ ! -n "$last_version" ]]; then | ||
| echo -e "${red}refresh x-ui version failed,it may due to Github API restriction,please try it later${plain}" |
There was a problem hiding this comment.
Correcting grammar:
echo -e "${red}refresh x-ui version failed, it might be due to GitHub API restriction, please again later${plain}"
| echo -e "${red}refresh x-ui version failed,it may due to Github API restriction,please try it later${plain}" | ||
| exit 1 | ||
| fi | ||
| echo -e "get x-ui latest version succeed:${last_version},begin to install..." |
There was a problem hiding this comment.
Change from:
echo -e "get x-ui latest version succeed:${last_version},begin to install..."
to:
echo -e "getting x-ui latest version succeed:${last_version},begin to install..."
| echo -e "get x-ui latest version succeed:${last_version},begin to install..." | ||
| wget -N --no-check-certificate -O /root/x-ui-linux-${arch}-english.tar.gz https://github.com/FranzKafkaYu/x-ui/releases/download/${last_version}/x-ui-linux-${arch}-english.tar.gz | ||
| if [[ $? -ne 0 ]]; then | ||
| echo -e "${red}dowanload x-ui failed,please be sure that your server can access Github{plain}" |
There was a problem hiding this comment.
Correct spelling and grammar.
Change from:
echo -e "${red}dowanload x-ui failed,please be sure that your server can access Github{plain}"
to:
echo -e "${red}downloading x-ui failed, please make sure that your server can access GitHub{plain}"
| echo -e "begin to install x-ui v$1 ..." | ||
| wget -N --no-check-certificate -O /root/x-ui-linux-${arch}-english.tar.gz ${url} | ||
| if [[ $? -ne 0 ]]; then | ||
| echo -e "${red}dowanload x-ui v$1 failed,please check the verison exists${plain}" |
There was a problem hiding this comment.
Spelling issues
- change dowanload to download.
- change verison to version.
- Correcting grammar.
from:
echo -e "${red}dowanload x-ui v$1 failed,please check the verison exists${plain}"
to:
echo -e "${red}downloading x-ui v$1 failed,please check exciting version${plain}"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I wanted to write the English version of the Docker file with your code and the code of @chasing66 who wrote the Docker file.
I did this, but when it comes up, the xray doesn't work properly. I wanted to see what you think