Repository navigation
feat: add date from/to filter to mail archive listing - #151
Merged
Merged
Conversation
Adds two date pickers to the filter sidebar of the mail archive listing to filter mails by their sent date (createdAt) within a from-to range. The selected dates are normalized to local day boundaries (00:00:00 - 23:59:59.999) and applied as a range filter. Also resets the transport state filter when using the reset filter button, as it was previously kept. Closes #144 Co-authored-by: xai <xai@shyim.de>
Member
Author
|
@frosh-ci create-instance |
Contributor
|
Hey 👋, I have created for you a Shopware installation with the current changes made here. You can access the Shop here: https://bfe5deo-2a6h5nb2dmuf8.zrh2.namespaced.app The URL is only for FriendsOfShopware members. |
Member
Author
|
@frosh-ci format-cs |
Member
Author
|
@frosh-ci fix-cs |
Contributor
|
Code style has been fixed and pushed to the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #144
What
Adds a date range filter (from – to) to the filter sidebar of the mail archive listing, so archived mails can be filtered by their sent date (
createdAt).How
sw-datepickerfields (dateType="date") in the filter sidebar, using the samedeprecatedcompatibility pattern as the existing fields, so the module keeps working on Shopware 6.6 and 6.7from→ 00:00:00.000,to→ 23:59:59.999) and applied as aCriteria.range('createdAt', { gte, lte })filter — the same approach Shopware core uses in its ownsw-date-filtersaveFilters/updateData), so filtered views stay shareable via URLdateFrom/dateToforen-GBandde-DEAlso fixed
Testing
check-snippetsCI workflow)sw-datepickerwrapper API (v-model:value,deprecatedprop, emitted value format) verified against the Shopware 6.7 core sources