Skip to content

Use non-deprecated DAL result access in mail validation - #94

Merged
shyim merged 3 commits into
mainfrom
copilot/fix-check-highest-github-actions-job
Oct 7, 2026
Merged

shyim merged 3 commits into
mainfrom
copilot/fix-check-highest-github-actions-job

Conversation

Copilot AI commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

The highest-version Actions check failed because Shopware 6.8 deprecates EntitySearchResult::first().

  • Compatibility: Retrieve the mail-template type through getEntities()->first().
  • Regression coverage: Verify the resolved technical name is passed to the mail finder.
$mailTemplateType = $repository->search($criteria, $context)->getEntities()->first();

Copilot AI and others added 2 commits October 6, 2026 18:37
Co-authored-by: shyim <6224096+shyim@users.noreply.github.com>
Co-authored-by: shyim <6224096+shyim@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job check (highest) Use non-deprecated DAL result access in mail validation Oct 6, 2026
Copilot AI requested a review from shyim October 6, 2026 18:38
@shyim
shyim marked this pull request as ready for review October 7, 2026 04:00
@shyim
shyim merged commit 0e8955e into main Oct 7, 2026
2 of 3 checks passed
@shyim
shyim deleted the copilot/fix-check-highest-github-actions-job branch October 7, 2026 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants