Repository navigation
feat: configurable check-in margin and max runtime for scheduled task monitors - #43
Merged
shyim merged 2 commits intoSep 3, 2026
Conversation
… monitors Monitors are upserted with only a schedule, so Sentry expects the check-in exactly at the scheduled minute. The task runner fires a few seconds later and the run is reported as missed (FriendsOfShopware#19). Claude-Session: https://claude.ai/code/session_01G2xLjqD8vZ7Ys3inHx4ax5
Member
Author
|
The failing phpstan job is the pre-existing failure on main (PHPStan 1.x vs. the symfony/config generics); #44 fixes it. Happy to rebase once that is in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19
ScheduledTaskSubscriberupserts monitors with only a schedule, so Sentry expects the check-in exactly at the scheduled minute. The task runner fires a few seconds after that minute, and Sentry reports the run as missed. In our project this produced about one false "Cron failure" issue per day for an hourly task that ran fine every time.This adds two optional settings that are passed through to
MonitorConfig:Both default to
null, so existing setups keep Sentry's monitor defaults.https://claude.ai/code/session_01G2xLjqD8vZ7Ys3inHx4ax5