Skip to content

Fix deprecated Symfony method call - #1990

Merged
XWB merged 1 commit into
FriendsOfSymfony:masterfrom
pkruithof:fix-symfony8-deprecation
May 21, 2026
Merged

XWB merged 1 commit into
FriendsOfSymfony:masterfrom
pkruithof:fix-symfony8-deprecation

Conversation

@pkruithof

Copy link
Copy Markdown
Contributor

Fixes #1988

Comment thread src/Subscriber/PaginateElasticaQuerySubscriber.php
Comment thread src/Subscriber/PaginateElasticaQuerySubscriber.php
@pkruithof

Copy link
Copy Markdown
Contributor Author

@XWB can you let me know how you want to proceed with this? We're updating our dependencies so we can upgrade to Symfony 8, this is one of the last remaining dependencies that's not yet compatible.

@XWB

XWB commented May 21, 2026 •

Copy link
Copy Markdown
Member

@pkruithof I think we're good for now. I believe PaginateElasticaQuerySubscriber is only used for GET requests.

@XWB XWB self-assigned this May 21, 2026
@XWB
XWB self-requested a review May 21, 2026 22:44
@XWB
XWB merged commit 1279fab into FriendsOfSymfony:master May 21, 2026
20 checks passed
@pkruithof
pkruithof deleted the fix-symfony8-deprecation branch May 26, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Symfony 8: Request::get() usage causes fatal error in PaginateElasticaQuerySubscriber

2 participants