Repository navigation
Conversation
guillaume-sainthillier
force-pushed
the
claude/laughing-carson-byUX1
branch
from
May 26, 2026 10:17
cfa253b to
567d57f
Compare
XWB
approved these changes
May 28, 2026
Member
|
Just one merge conflict. |
Apply Rector with PHP 8.1 sets plus dead code, code quality, type declarations, privatization, and early return prepared sets. Main changes: - Constructor property promotion and readonly properties - Add missing void/typed return types - Remove redundant @return/@var phpdocs - Replace isset() with null comparison on typed properties - Drop ReflectionProperty::setAccessible() calls (no-op since PHP 8.1) - Fix incorrect TCallbackInternal type (ExpressionLanguage -> Expression)
Add explicit parameter types to closures and arrow functions where the type can be inferred unambiguously from context: - Event listener closures typed with their event class - Config DSL ifTrue/then callbacks typed as array or mixed - usort/array_map callbacks in transformer typed as array|object - PropertyAccessor mock callback typed (object, string)
Run Rector with type coverage level 100 plus manual passes to add types to every method, interface, and anonymous function across src/ and tests/. - Interface return types and param types (Finder, ObjectPersister, Paginator, Pager, ElasticaToModelTransformer, HighlightableModel) - Implementation methods updated to match (TransformedFinder, Repository, RawPaginatorAdapter, FantaPaginatorAdapter, HybridResult, AbstractElasticaToModelTransformer, Doctrine transformers) - Configuration DSL arrow function param/return types - Test fixture POPO getters typed from property declarations - Test mock repositories typed to return their QueryBuilder type
guillaume-sainthillier
force-pushed
the
claude/laughing-carson-byUX1
branch
from
May 28, 2026 08:53
567d57f to
305fbfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply Rector with PHP 8.1 sets plus dead code, code quality, type declarations, privatization, and early return prepared sets.
Main changes: