Skip to content

Inform to expose routes annotation before run dump #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Inform to expose routes annotation before run dump #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Resources/doc/usage.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ In applications not using webpack add these two lines in your layout:
If you are using webpack and Encore to package your assets you will need to use the dump command
and export your routes to json, this command will create a json file into the ``web/js`` folder:

.. note::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note is in the wrong place, as the previous paragraph expects to be followed by the code block.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand we just have to change section part of documention and put expose section on top before the dump section. What do you think ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that would be a nice solution.


If you are using annotations for routing you have to expose your routes before running this command
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not limited to annotations. Configuring which routes are exposed should always be done before dumping (as the dump will only include the exposed routes).


.. code-block:: bash

# Symfony 3
Expand Down