Responses with HTTP status 204/ 304 must not set the Content-Type header#2298
Open
kryptychon wants to merge 1 commit intoFriendsOfSymfony:3.xfrom
Open
Responses with HTTP status 204/ 304 must not set the Content-Type header#2298kryptychon wants to merge 1 commit intoFriendsOfSymfony:3.xfrom
kryptychon wants to merge 1 commit intoFriendsOfSymfony:3.xfrom
Conversation
Member
|
makes sense, could you please add a test for this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
IMHO the
Content-Typeheader must not be set if theViewHandleris dealing with an emptyResponse.I'm aware this might break BC but nevertheless, a Content-Type header does not really make sense in an empty response.