refactor(Record/Filter): Improve the code readability #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filters had been touched during the work on the support for PHP 8. I had cleaned this part, but the code was not ready to merge. * Add proof that every element of the code of Record Filter works as it should. It keeps the current behaviour, even if it seems a bug. * Fix the code structure of the test and the code.
thePanz
force-pushed
the
fix-code-structure-of-record-filter
branch
from
ec39d2c to
05540b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filters had been touched during the work on the support for PHP 8.
I had cleaned this part, but the code was not ready to merge.
See c6baf4d#r939602330
It keeps the current behaviour, even if it seems a bug.