Skip to content

Added support for PHP 8.4 #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Added support for PHP 8.4 #382

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
355392f
[ci] added php 8.4
thirsch Jan 26, 2025
a1af14d
PHP 8.4 > Removed deprecated constant E_STRICT, as it is not in use s…
thirsch Jan 26, 2025
ab85e29
updated README.md to reflect supported php versions.
thirsch Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
- "8.1"
- "8.2"
- "8.3"
- "8.4"
memcached-version:
- "1.6"

Expand Down
8 changes: 1 addition & 7 deletions lib/log/sfWebDebugLogger.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ public function initialize(sfEventDispatcher $dispatcher, $options = [])
* PHP error handler send PHP errors to log.
*
* PHP user space error handler can not handle E_ERROR, E_PARSE,
* E_CORE_ERROR, E_CORE_WARNING, E_COMPILE_ERROR, E_COMPILE_WARNING,
* and most of E_STRICT.
* E_CORE_ERROR, E_CORE_WARNING, E_COMPILE_ERROR and E_COMPILE_WARNING.
*
* @param string $errno the level of the error raised, as an integer
* @param string $errstr the error message, as a string
Expand All @@ -76,11 +75,6 @@ public function handlePhpError($errno, $errstr, $errfile, $errline, $errcontext
$message = sprintf(' %%s at %s on line %s (%s)', $errfile, $errline, str_replace('%', '%%', $errstr));

switch ($errno) {
case E_STRICT:
$this->dispatcher->notify(new sfEvent($this, 'application.log', ['priority' => sfLogger::ERR, sprintf($message, 'Strict notice')]));

break;

case E_NOTICE:
$this->dispatcher->notify(new sfEvent($this, 'application.log', ['priority' => sfLogger::NOTICE, sprintf($message, 'Notice')]));

Expand Down
Loading