Skip to content

[ENHANCEMENT] Split GF characters from their Speakers #5153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

KoloInDaCrib
Copy link
Contributor

Linked Issues

Closes #5111

Description

This PR introduces a new scriptable class, Boombox. (the name Speaker was already occupied by the dialogue speaker) It's essentially just an FlxSpriteGroup with a support for the same events as the characters. It only works on GF and receives event calls before GF. The position of the Boombx depends on the stage json's position for the girlfriend and the offsets defined in the character json.

At the moment I have only done this for the default versions of Nene and A-Bot, though I'd like to update this at some point to include other versions of A-Bot and Nene.
GF will take a bit though considering the back side of her hair would need to be separated from the rest of her body (hence the branch name bald-gf).

also can you guys merge the latest changes from the main assets branch onto develop please i swear i didn't touch the labeller files i just pulled from main to have an assets submod base okay thanks

Screenshots/Videos

Video Preview
A-Bot.Hi.A-Bot.mp4
Character Boombox Configuration

image

@github-actions github-actions bot added status: pending triage Awaiting review. pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. and removed status: pending triage Awaiting review. labels May 24, 2025
@AbnormalPoof AbnormalPoof added type: enhancement Involves an enhancement or new feature. status: pending triage Awaiting review. topic: mods Related to the creation or use of mods. labels May 24, 2025
@Lasercar
Copy link
Contributor

Why is the boombox only used if the character is used in the GF position?

The Tutorial places GF in the opponent position.

@TechnikTil
Copy link
Contributor

image

TechnikTil

This comment was marked as resolved.

@TechnikTil
Copy link
Contributor

KoloInDaCrib#5
helping out a fellow pr'r (that works)

@TechnikTil
Copy link
Contributor

image

image

Copy link
Contributor

@TechnikTil TechnikTil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops i forgot to change my review

anyway
this works

@Hundrec Hundrec linked an issue Jun 30, 2025 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. topic: mods Related to the creation or use of mods. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Separate speakers from the girlfriend character
4 participants