Skip to content

[ENHANCEMENT] Display an Indicator for Note Kinds in Chart Editor #5284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2025
Merged

[ENHANCEMENT] Display an Indicator for Note Kinds in Chart Editor #5284

merged 2 commits into from
Aug 2, 2025

Conversation

KoloInDaCrib
Copy link
Contributor

Linked Issues

Closes #5271

Description

Adds a new toggle under View, Note Kind Indicator which is on by default. With this enabled, notes with custom notekinds will have a little star next to them to separate them from the normal notes. To add to this change, I added tooltip support for notes so that the user knows exactly which notekind the note is (tooltip is disabled if the note is the of the default kind.)

Screenshots/Videos

twinkle.twinkle.notekind.star.mp4

@github-actions github-actions bot added status: pending triage Awaiting review. size: large A large pull request with more than 100 changes. pr: haxe PR modifies game code. and removed status: pending triage Awaiting review. size: large A large pull request with more than 100 changes. labels Jul 2, 2025
@KoloInDaCrib KoloInDaCrib mentioned this pull request Jul 2, 2025
Merged
@Hundrec Hundrec added status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. size: large A large pull request with more than 100 changes. type: enhancement Involves an enhancement or new feature. labels Jul 2, 2025
@Hundrec Hundrec linked an issue Jul 3, 2025 that may be closed by this pull request
Enhancement: Visual Indicator for Notekinds in Chart Editor #5271
Closed
3 tasks
@sphis-sinco
Copy link
Contributor

sphis-sinco commented Jul 5, 2025 •
edited
Loading

Add support for custom indicator images. I beg you.

@Hundrec Hundrec changed the base branch from develop to dummy/develop-0.6.4 August 2, 2025 11:52
@Hundrec Hundrec added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Aug 2, 2025
@AbnormalPoof AbnormalPoof changed the base branch from dummy/develop-0.6.4 to develop August 2, 2025 14:15
@AbnormalPoof
Copy link
Member

I will also rebase this

@sphis-sinco
Copy link
Contributor

Please.

@AbnormalPoof AbnormalPoof force-pushed the this-took-me-three-DAYS-to-compile branch from 258b13d to 712db54 Compare August 2, 2025 14:30
@github-actions github-actions bot added size: huge A huge pull request with more than 500 changes. and removed size: large A large pull request with more than 100 changes. labels Aug 2, 2025
@AbnormalPoof AbnormalPoof force-pushed the this-took-me-three-DAYS-to-compile branch from 712db54 to 48e5549 Compare August 2, 2025 14:32
@github-actions github-actions bot added size: large A large pull request with more than 100 changes. and removed size: huge A huge pull request with more than 500 changes. labels Aug 2, 2025
@AbnormalPoof AbnormalPoof force-pushed the this-took-me-three-DAYS-to-compile branch from 48e5549 to 888417a Compare August 2, 2025 14:34
@AbnormalPoof AbnormalPoof force-pushed the this-took-me-three-DAYS-to-compile branch from 888417a to fba05fb Compare August 2, 2025 14:35
@AbnormalPoof AbnormalPoof removed the status: reviewing internally Under consideration and testing. label Aug 2, 2025
@AbnormalPoof AbnormalPoof added the status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. label Aug 2, 2025
@AbnormalPoof AbnormalPoof added this to the 0.7.4 milestone Aug 2, 2025
AbnormalPoof
AbnormalPoof approved these changes Aug 2, 2025
View reviewed changes
Copy link
Member

@AbnormalPoof AbnormalPoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

krue......

@AbnormalPoof AbnormalPoof merged commit d75e0af into FunkinCrew:develop Aug 2, 2025
4 checks passed
@KoloInDaCrib KoloInDaCrib deleted the this-took-me-three-DAYS-to-compile branch August 2, 2025 16:50
@Hundrec Hundrec added the topic: changes assets Modifies the assets submodule, or has an associated pull request in the funkin.assets repository. label Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbnormalPoof AbnormalPoof AbnormalPoof approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: changes assets Modifies the assets submodule, or has an associated pull request in the funkin.assets repository. topic: chart editor Related to the operation of the Chart Editor. type: enhancement Involves an enhancement or new feature.
Milestone
0.7.4
Development

Successfully merging this pull request may close these issues.

Enhancement: Visual Indicator for Notekinds in Chart Editor
4 participants
@KoloInDaCrib @sphis-sinco @AbnormalPoof @Hundrec