[BUGFIX] Fix instances of song metadata not assigning variation correctly #5401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr: haxe
Hundrec
added
type: minor bug
NotHyper-474
changed the title
NotHyper-474
changed the title
|
eric................... |
what do you mean by eric... |
…....................................................................................................................................
NotHyper-474
force-pushed
the
bugfix/torso-of-the-week
branch
from
65ccad9 to
19b5531
Compare
Hundrec
added
status: reviewing internally
Ah, I was more on about how it took adding and saving a variation to notice that I completely forgot about the all the new uses of the song metadata. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Fixes #5400
Description
A PR made a change to
SongMetadata's constructor to fix the charter not being saved but forgot to change many instances where it was being used, causing the variation to benull(which falls back todefault) and the charter to have the variation's name. In the linked issue, when adding a new variation this caused the default variation to be replaced by the new one (hence the difficulties wiped)This PR changes it so all instances of
new SongMetadataassign the arguments correctly which should fix some other unnoticed issues as well.P.S: I've also noticed the New Song wizard window is missing a charter field, I would fix that but that's gonna require an assets PR, maybe for another PR.
Screenshots/Videos
TBA (maybe)