-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[ENHANCEMENT] [MODS] Freeplay difficulty dots rework [FREEPLAY] #5746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PurSnake
wants to merge
23
commits into
FunkinCrew:develop
Choose a base branch
from
PurSnake:freeplay-dots-rework
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yall add this please |
We need this. |
6cad90b
to
bd48ca4
Compare
3 tasks
How many commits???? You should consider running a interactive rebase to squash them into one |
Don't worry about it, I have git powers now |
Average chore PR |
I saw a discussion where somebody mentioned that the colors of the dots were hardcoded. Would it be possible to include support for custom dot colors in this PR? |
…eplay-dots-rework
This reverts commit 9a54046.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: haxe
PR modifies game code.
size: huge
A huge pull request with more than 500 changes.
status: needs revision
Cannot be approved because it is awaiting some work by the contributor.
topic: freeplay
Related to the operation of the Freeplay menu.
topic: mods
Related to the creation or use of mods.
type: enhancement
Involves an enhancement or new feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Some issues with broken by mods difficulty dots ig
Description
Simply:
Some other fixes and stuff i did in this pr
And now Difficulty dots FUNKIN WORKS WITH MODS YEY PROPERLY :D
And my re-implementation is kinda funny for me, cuz thats exactly how i imagined these dots to work from the first screenshots in the app store.
Screenshots/Videos
Before --------------------------------------------------------------- After

If anything goes wrong, I'm selling my soul to FunkinCrew