[ENHANCEMENT] Change Animation Editor save shortcuts #5974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr: haxe
|
Awesome! |
AbnormalPoof
added
type: enhancement
3 tasks
Hundrec
added
the
topic: changes assets
Hundrec
force-pushed
the
animation-editor-save-hotkeys
branch
from
ac4465d to
80378be
Compare
Hundrec
added
status: reviewing internally
Hundrec
added
status: accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Closes #5931
Description
The current shortcut for saving offsets in the Animation Editor is Ctrl+Esc, but on Windows, this shortcut opens the start menu.
This PR changes the shortcuts for saving files in the Animation Editor to Ctrl+S and Ctrl+Shift+S. (Ctrl+S for saving character data, Ctrl+Shift+S for saving offsets)
I chose these shortcuts for consistency as both the chart editor and stage editor use these shortcuts for saving files.
Associated Funkin Assets PR
FunkinCrew/funkin.assets#253
This PR is necessary to change the labels to the new shortcuts in the dialog that lists all of the shortcuts.