-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add proper HashLink support #6135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
2bc4629
to
67fd8e1
Compare
If any features have to be disabled (like video cutscenes), you should make sure to disable them in the |
Oh my lord please work. |
2ac04f9
to
e7ab4db
Compare
VSlice_HL_COMPILING.zip |
That's because you need the change from FunkinCrew/openfl#7 Maybe I should put back the commits from the PRs in the |
thatd make it ezer 😅 |
ill test it soon |
Pull the commit I just pushed and try again, I forgot my fork had a different name lel |
![]() another error but I have a fix for this cuz its happened to me be4 PolymodAbstractScriptClass.txt(txt becuz github's a [[uh-oh]]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works but (I'm suspecting) lime keeps fucking it over. Least for me.
I think you may need to rebuild Lime for HashLink with |
b5806a1
to
44d8a7f
Compare
I managed to rebuild HL on Windows, but for some reason the game just refuses to open bruh, this is some freaking bullshit. |
oh ok |
ok yeah game didnt open for some reason |
21268e8
to
b9f9609
Compare
kk |
Apparently cutsceneType was null. /**
* The default callback used when a cutscene is finished.
* You can specify your own callback when calling `VideoCutscene#play()`.
*/
static function onCutsceneFinish(cutsceneType:CutsceneType):Void
{
try
{
switch (cutsceneType)
{
case CutsceneType.STARTING:
PlayState.instance.startCountdown();
case CutsceneType.ENDING:
PlayState.instance.endSong(true); // true = right goddamn now
case CutsceneType.MIDSONG:
// Do nothing.
// throw "Not implemented!";
}
}
catch (e)
{
if (FlxG.sound.music.endTime != null
&& FlxG.sound.music.time >= FlxG.sound.music.endTime) PlayState.instance.endSong(true); // true = right goddamn now
else
PlayState.instance.startCountdown();
}
} |
Was that after reinstalling flixel? |
yeah |
you forgot the flxSignal changes |
Are you sure the changes are not there? |
I installed the flixel changes from the wrong hmm file WHOOOPS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hashlink is real.
f452057
to
c1a2337
Compare
04b6c2f
to
f8b7a9a
Compare
f8b7a9a
to
b25730b
Compare
Decided to remove the changes to the hmm file and put them in a gist I've included in the description, I'll be updating it as needed. |
9d0d8f4
to
62695a9
Compare
Co-authored-by: Sinco <[email protected]>
877ea3d
to
b6c8a3f
Compare
Linked Issues
Closes #4138
Description
This is quite an old branch of mine that's been sitting on my repository since 2024, finally becoming a PR now that there seems to be a growing interest in building for HashLink. It aims to fix issues that would prevent someone from compiling to HashLink, which could be a pretty useful target for easily making and testing PRs like I did when making #3574.
Feel free to try it out and report any issues you have in the replies!
NOTE: Use the hmm file below to use the forks with the proper fixes for HashLink.
https://gist.github.com/NotHyper-474/deda870cdc722300982c7814ad5c1254
Dependent on:
6f8ee63
(#7) which fixes a bug with Flixel signals not being removed, causing crashes.OutOfBounds
fix when nolime_vorbis
and a bit of refactoring FlxPartialSound#4Known Issues
Fixed by larsiusprime/polymod@DropShadowShader
is utterly broken.045372c
(#258)Advancing in a Conversation causes a crash.Also fixed by the commit above.Chart Editor may randomly crash while messing around.Turns out it's just a bug with HaxeUI.Lime can build but cannot open a debug session.Fixed!WiggleEffect shader crashes the game by trying to cast an enum to an int.Fixed by OpenFL PR.Some Focus Camera events aren't able to be properly parsed, which causes a crash.Screenshots/Videos