Skip to content

[BUGFIX] Fix Subtitle HTML tags #6299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Hundrec merged 1 commit into from
Oct 20, 2025
Merged

[BUGFIX] Fix Subtitle HTML tags #6299

Hundrec merged 1 commit into from
Oct 20, 2025

Conversation

@TechnikTil
Copy link
Contributor

@TechnikTil TechnikTil commented Oct 18, 2025 •
edited
Loading

Description

Originally, FlxText would override the HTML format tags added through htmlText by adding its own formatting every text edit. This PR makes sure that those HTML tags don't get overriden by disabling FlxText's applyFormat behavior.

Screenshots/Videos

Before:
image

After:
image

@github-actions github-actions bot added status: pending triage Awaiting review. size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. labels Oct 18, 2025
This was referenced Oct 18, 2025
Open
Open
@AbnormalPoof AbnormalPoof added the type: minor bug Involves a minor bug or issue. label Oct 18, 2025
@MAZ12211
Copy link

MAZ12211 commented Oct 18, 2025

Bumping this up

@AbnormalPoof AbnormalPoof force-pushed the bugfix/html-text-subtitles branch from 697b871 to 95896c3 Compare October 19, 2025 00:48
@AbnormalPoof AbnormalPoof added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Oct 19, 2025
@TechnikTil
Copy link
Contributor Author

TechnikTil commented Oct 19, 2025

rah
image

@Hundrec Hundrec changed the base branch from develop to dummy/develop-v0.7.5 October 20, 2025 04:15
@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Oct 20, 2025
@Hundrec Hundrec added this to the 0.7.6 milestone Oct 20, 2025
@Hundrec Hundrec merged commit dd1f006 into FunkinCrew:dummy/develop-v0.7.5 Oct 20, 2025
6 checks passed
@MAZ12211
Copy link

MAZ12211 commented Oct 20, 2025

Let's gooooo

@whizchisOfficial1
Copy link

whizchisOfficial1 commented Oct 20, 2025

Dude this is sick! Subtitles in Funkin’ are fixed!! What if the Subtitles Had Character Based Detection + Color Detection or players could be able to change the Font color and font background colors? Not necessary either.

@TechnikTil
Copy link
Contributor Author

TechnikTil commented Oct 21, 2025

Dude this is sick! Subtitles in Funkin’ are fixed!! What if the Subtitles Had Character Based Detection + Color Detection or players could be able to change the Font color and font background colors? Not necessary either.

You can change the font color

@whizchisOfficial1
Copy link

whizchisOfficial1 commented Oct 23, 2025

Mmm I see now, that’s actually really cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.

Milestone

0.7.6

Development

Successfully merging this pull request may close these issues.

5 participants

@TechnikTil @MAZ12211 @whizchisOfficial1 @AbnormalPoof @Hundrec