Skip to content

Conversation

@tduhamel42
Copy link
Collaborator

This release includes critical bug fixes and CLI improvements from PR #19.

What's Changed

Worker Naming Fixes

  • Fixed worker container naming mismatch between CLI and docker-compose
  • Updated worker_manager.py to use docker compose commands with service names
  • Removed worker_container field from workflows API
  • Backend now correctly uses service names (worker-python, worker-secrets, etc.)

Backend API Fixes

  • Fixed workflow name extraction from run_id in runs.py (was showing "unknown")
  • Updated monitor command suggestions to use correct monitor live syntax

Monitor Command Consolidation

  • Merged monitor stats and monitor live into single monitor live command
  • Added --once and --style flags for flexible monitoring
  • Removed all references to deprecated monitor stats command

Findings CLI Structure Improvements

Closes #18

  • Moved show command from findings (plural) to finding (singular) for better UX
  • Kept export command in findings (plural) as it exports all findings
  • Removed broken analyze command that imported non-existent function
  • Updated all command suggestions throughout codebase
  • Fixed smart routing logic in main.py
  • Added export suggestions with unique timestamps to prevent overwriting
  • Changed default export format to SARIF (industry standard)

Docker Compose

  • Removed obsolete version field to fix deprecation warning

Testing

All commands have been tested and verified working:

  • ff finding show <run-id> --rule <rule-id> - Show detailed finding
  • ff findings export <run-id> - Export all findings from run
  • ff finding <run-id> - Direct viewing of findings
  • ff monitor live <run-id> - Real-time monitoring

Files Changed

  • 9 files changed, 283 insertions(+), 204 deletions(-)

- Added exception in .gitignore for benchmark results directory
- Force-added comparison_report.md and comparison_results.json
- These files contain benchmark metrics, not actual secrets
- Fixes broken link in README to benchmark results
This PR addresses multiple issues and improvements across the CLI and backend:

**Worker Naming Fixes:**
- Fix worker container naming mismatch between CLI and docker-compose
- Update worker_manager.py to use docker compose commands with service names
- Remove worker_container field from workflows API, keep only worker_service
- Backend now correctly uses service names (worker-python, worker-secrets, etc.)

**Backend API Fixes:**
- Fix workflow name extraction from run_id in runs.py (was showing "unknown")
- Update monitor command suggestions from 'monitor stats' to 'monitor live'

**Monitor Command Consolidation:**
- Merge 'monitor stats' and 'monitor live' into single 'monitor live' command
- Add --once and --style flags for flexibility
- Remove all references to deprecated 'monitor stats' command

**Findings CLI Structure Improvements (Closes #18):**
- Move 'show' command from 'findings' (plural) to 'finding' (singular)
- Keep 'export' command in 'findings' (plural) as it exports all findings
- Remove broken 'analyze' command (imported non-existent function)
- Update all command suggestions to use correct paths
- Fix smart routing logic in main.py to handle new command structure
- Add export suggestions after viewing findings with unique timestamps
- Change default export format to SARIF (industry standard)

**Docker Compose:**
- Remove obsolete version field to fix deprecation warning

All commands tested and working:
- ff finding show <run-id> --rule <rule-id> ✓
- ff findings export <run-id> ✓
- ff finding <run-id> (direct viewing) ✓
- ff monitor live <run-id> ✓
…-version

fix: worker naming, monitor commands, and findings CLI improvements
@tduhamel42 tduhamel42 merged commit 4e14b42 into master Oct 21, 2025
6 checks passed
tduhamel42 added a commit that referenced this pull request Nov 4, 2025
Release: v0.7.1 - Worker fixes, monitor consolidation, and findings improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] add export command when showing fuzzforge finding security_assessment-29c04772

2 participants