Skip to content

Conversation

@Ruthgyeul
Copy link
Member

#️⃣연관된 이슈

#102

📝작업 내용

여러 프로젝트 실행 충돌을 방지하기 위한 CI/CD 스크립트 업데이트

@Ruthgyeul Ruthgyeul requested a review from Copilot May 12, 2025 09:49
@Ruthgyeul Ruthgyeul self-assigned this May 12, 2025
@Ruthgyeul Ruthgyeul added FIX 오류를 고쳤을 때 REFACTOR 구조를 다르게 하여 개선하였을 때 💻 MASTER Master PR 요청 labels May 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI/CD scripts to prevent conflicts when running multiple projects simultaneously. The changes include:

  • Updating appspec.yml to use the gdgocinha-fe subdirectory for files and deploy hooks.
  • Modifying the deploy workflow to create a structured deployment package with separate directories (including nginx and logs).

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
appspec.yml Updated file paths and permissions to target the gdgocinha-fe subdirectory.
.github/workflows/deploy.yml Revised deployment package creation including new directory structure and file locations.
Comments suppressed due to low confidence (2)

appspec.yml:13

  • The updated deploy script path now reflects the new subdirectory structure; please verify that this change is consistent with the deployment package structure defined in the workflow.
+    - location: gdgocinha-fe/deploy.sh

.github/workflows/deploy.yml:60

  • [nitpick] Ensure that zipping the package from the deploy-package directory does not inadvertently include any unintended files and that the resulting structure meets the production deployment requirements.
+          zip -r ../deploy-gdgocinha-fe.zip .

Comment on lines +37 to +53
mkdir -p deploy-package/gdgocinha-fe
# Copy necessary files
cp scripts/deploy.sh deploy-package/gdgocinha-fe/
cp docker-compose.yml deploy-package/gdgocinha-fe/
cp appspec.yml deploy-package/gdgocinha-fe/
cp gdgocinha-fe/.env deploy-package/gdgocinha-fe/
# Copy nginx configuration
mkdir -p deploy-package/gdgocinha-fe/nginx
cp nginx/gdgocinha.com.conf deploy-package/gdgocinha-fe/nginx/
# Create logs directory
mkdir -p deploy-package/gdgocinha-fe/logs
mkdir -p deploy-package/gdgocinha-fe/logs/docker
mkdir -p deploy-package/gdgocinha-fe/logs/app
mkdir -p deploy-package/gdgocinha-fe/logs/deploy
Copy link

Copilot AI May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding additional comments to explain the purpose of each newly created directory (e.g., nginx and logs) to improve maintainability.

Suggested change
mkdir -p deploy-package/gdgocinha-fe
# Copy necessary files
cp scripts/deploy.sh deploy-package/gdgocinha-fe/
cp docker-compose.yml deploy-package/gdgocinha-fe/
cp appspec.yml deploy-package/gdgocinha-fe/
cp gdgocinha-fe/.env deploy-package/gdgocinha-fe/
# Copy nginx configuration
mkdir -p deploy-package/gdgocinha-fe/nginx
cp nginx/gdgocinha.com.conf deploy-package/gdgocinha-fe/nginx/
# Create logs directory
mkdir -p deploy-package/gdgocinha-fe/logs
mkdir -p deploy-package/gdgocinha-fe/logs/docker
mkdir -p deploy-package/gdgocinha-fe/logs/app
mkdir -p deploy-package/gdgocinha-fe/logs/deploy
mkdir -p deploy-package/gdgocinha-fe # Root directory for the deployment package
# Copy necessary files
cp scripts/deploy.sh deploy-package/gdgocinha-fe/ # Deployment script
cp docker-compose.yml deploy-package/gdgocinha-fe/ # Docker Compose configuration
cp appspec.yml deploy-package/gdgocinha-fe/ # AWS CodeDeploy configuration
cp gdgocinha-fe/.env deploy-package/gdgocinha-fe/ # Environment variables
# Copy nginx configuration
mkdir -p deploy-package/gdgocinha-fe/nginx # Directory for nginx configuration files
cp nginx/gdgocinha.com.conf deploy-package/gdgocinha-fe/nginx/ # Main nginx configuration file
# Create logs directory
mkdir -p deploy-package/gdgocinha-fe/logs # Root directory for application logs
mkdir -p deploy-package/gdgocinha-fe/logs/docker # Directory for Docker-related logs
mkdir -p deploy-package/gdgocinha-fe/logs/app # Directory for application-specific logs
mkdir -p deploy-package/gdgocinha-fe/logs/deploy # Directory for deployment process logs

Copilot uses AI. Check for mistakes.
@Ruthgyeul Ruthgyeul merged commit 20ab19e into master May 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FIX 오류를 고쳤을 때 💻 MASTER Master PR 요청 REFACTOR 구조를 다르게 하여 개선하였을 때

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants