-
Notifications
You must be signed in to change notification settings - Fork 3
Update: 여러 프로젝트 실행 충돌을 방지하기 위한 CI/CD 스크립트 업데이트 #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the CI/CD scripts to prevent conflicts when running multiple projects simultaneously. The changes include:
- Updating appspec.yml to use the gdgocinha-fe subdirectory for files and deploy hooks.
- Modifying the deploy workflow to create a structured deployment package with separate directories (including nginx and logs).
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| appspec.yml | Updated file paths and permissions to target the gdgocinha-fe subdirectory. |
| .github/workflows/deploy.yml | Revised deployment package creation including new directory structure and file locations. |
Comments suppressed due to low confidence (2)
appspec.yml:13
- The updated deploy script path now reflects the new subdirectory structure; please verify that this change is consistent with the deployment package structure defined in the workflow.
+ - location: gdgocinha-fe/deploy.sh
.github/workflows/deploy.yml:60
- [nitpick] Ensure that zipping the package from the deploy-package directory does not inadvertently include any unintended files and that the resulting structure meets the production deployment requirements.
+ zip -r ../deploy-gdgocinha-fe.zip .
| mkdir -p deploy-package/gdgocinha-fe | ||
| # Copy necessary files | ||
| cp scripts/deploy.sh deploy-package/gdgocinha-fe/ | ||
| cp docker-compose.yml deploy-package/gdgocinha-fe/ | ||
| cp appspec.yml deploy-package/gdgocinha-fe/ | ||
| cp gdgocinha-fe/.env deploy-package/gdgocinha-fe/ | ||
| # Copy nginx configuration | ||
| mkdir -p deploy-package/gdgocinha-fe/nginx | ||
| cp nginx/gdgocinha.com.conf deploy-package/gdgocinha-fe/nginx/ | ||
| # Create logs directory | ||
| mkdir -p deploy-package/gdgocinha-fe/logs | ||
| mkdir -p deploy-package/gdgocinha-fe/logs/docker | ||
| mkdir -p deploy-package/gdgocinha-fe/logs/app | ||
| mkdir -p deploy-package/gdgocinha-fe/logs/deploy |
Copilot
AI
May 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider adding additional comments to explain the purpose of each newly created directory (e.g., nginx and logs) to improve maintainability.
| mkdir -p deploy-package/gdgocinha-fe | |
| # Copy necessary files | |
| cp scripts/deploy.sh deploy-package/gdgocinha-fe/ | |
| cp docker-compose.yml deploy-package/gdgocinha-fe/ | |
| cp appspec.yml deploy-package/gdgocinha-fe/ | |
| cp gdgocinha-fe/.env deploy-package/gdgocinha-fe/ | |
| # Copy nginx configuration | |
| mkdir -p deploy-package/gdgocinha-fe/nginx | |
| cp nginx/gdgocinha.com.conf deploy-package/gdgocinha-fe/nginx/ | |
| # Create logs directory | |
| mkdir -p deploy-package/gdgocinha-fe/logs | |
| mkdir -p deploy-package/gdgocinha-fe/logs/docker | |
| mkdir -p deploy-package/gdgocinha-fe/logs/app | |
| mkdir -p deploy-package/gdgocinha-fe/logs/deploy | |
| mkdir -p deploy-package/gdgocinha-fe # Root directory for the deployment package | |
| # Copy necessary files | |
| cp scripts/deploy.sh deploy-package/gdgocinha-fe/ # Deployment script | |
| cp docker-compose.yml deploy-package/gdgocinha-fe/ # Docker Compose configuration | |
| cp appspec.yml deploy-package/gdgocinha-fe/ # AWS CodeDeploy configuration | |
| cp gdgocinha-fe/.env deploy-package/gdgocinha-fe/ # Environment variables | |
| # Copy nginx configuration | |
| mkdir -p deploy-package/gdgocinha-fe/nginx # Directory for nginx configuration files | |
| cp nginx/gdgocinha.com.conf deploy-package/gdgocinha-fe/nginx/ # Main nginx configuration file | |
| # Create logs directory | |
| mkdir -p deploy-package/gdgocinha-fe/logs # Root directory for application logs | |
| mkdir -p deploy-package/gdgocinha-fe/logs/docker # Directory for Docker-related logs | |
| mkdir -p deploy-package/gdgocinha-fe/logs/app # Directory for application-specific logs | |
| mkdir -p deploy-package/gdgocinha-fe/logs/deploy # Directory for deployment process logs |
#️⃣연관된 이슈
📝작업 내용