GT-129 Cast all returns from Config.php to appropriate types#420
Open
GT-129 Cast all returns from Config.php to appropriate types#420
Conversation
- as per issue request, all returns from config.php are now explicitly cast to appropriate types - this is to prevent confusion and error as before returns were being cast as a SimpleXMLElement object which can cause unexpected behaviour - new lines were also added in and around some of the functions where they were missing to make the text more readable
Member
|
@gregcorbett I guess we don't have an existing unit test that could be extended to cover this? |
Member
|
I would presume not. |
Member
|
As discussed, @rowan04 would you be able to take a look at implementing a unit test to check the public methods in |
- A type cast had accidentally not been added to the getHeadingTextColour function, so has now been added
rowan04
force-pushed
the
413-cast-config-returns-to-appropriate-types
branch
from
54c3ace to
89756eb
Compare
Contributor
Author
|
The force push was to amend a commit name/message |
Contributor
Author
|
After doing some tests on some of the functions in Config.php, this type casting method works. However, there is still some work for me to do to create some proper unit tests |
gregcorbett
requested changes
Feb 6, 2023
Member
gregcorbett
left a comment
gregcorbett
left a comment
There was a problem hiding this comment.
Unit test writing that is in progress.
tofu-rocketry
changed the title
Contributor
Author
|
Unfortunately, due to me starting a new rotation, I am unable to write the unit tests for this pr. See #486 |
Contributor
Author
|
fixed conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #413